Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document editors that support MDX language server #475

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Document editors that support MDX language server #475

merged 3 commits into from
Dec 23, 2024

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

Both lsp-mode and nvim-lspconfig support the MDX language server.

Refs #474
Refs https://www.reddit.com/r/neovim/comments/1ewwtok/has_anyone_figured_out_intellisense_in_mdx_files/

@remcohaszing
Document editors that support MDX language server
9b1abdc 
Both `lsp-mode` and `nvim-lspconfig` support the MDX language server.
@remcohaszing remcohaszing added 📚 area/docs This affects documentation 🦋 type/enhancement This is great to have 👶 semver/patch This is a backwards-compatible fix 👍 phase/yes Post is accepted and can be worked on labels Aug 31, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 31, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9ef8041

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
wooorm
wooorm approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test both? Seems good to me but I have no experience with em

@remcohaszing
Copy link
Member Author

Yes, not in depth, but it works.

@remcohaszing remcohaszing merged commit 442d20c into main Dec 23, 2024
8 checks passed
@remcohaszing remcohaszing deleted the document-editor-integrations branch December 23, 2024 10:28
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@remcohaszing remcohaszing added the 💪 phase/solved Post is done label Dec 23, 2024
@github-actions github-actions bot removed the 👍 phase/yes Post is accepted and can be worked on label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
📚 area/docs This affects documentation 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remcohaszing @wooorm @ChristianMurphy